refactor: extract storenode cycle to go-waku #21494
Open
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (4)
|
richard-ramos
force-pushed
the
test/extract-storenode-cycle
branch
from
ec008ca
to
598d5f2
Compare
75% of end-end tests have passedFailed tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Expected to fail tests (1)Click to expandClass TestCommunityMultipleDeviceMerged:
Passed tests (6)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestWalletMultipleDevice:
|
60% of end-end tests have passedFailed tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Expected to fail tests (20)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMerged:
Passed tests (33)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestFallbackMultipleDevice:
Class TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestWalletMultipleDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
|
@richard-ramos thanks for the PR. Please take a look at the issue. ISSUE 1 Backed up data is not restoredSteps:
Expected result: data has been restored Actual result: data has not been restored |
ISSUE 2 Curated communities are not fetched in Discovery sectionSteps:
Expected result: curated communities are fetched Actual result: curated communities not fetched Status-debug-logs - 2024-11-07T172237.909.zip telegram-cloud-document-2-5289623460522255460.mp4 |
ISSUE 3 Communities are not fetchedSteps:
Expected result: community is fetched Actual result: community not fetched Status-debug-logs - 2024-11-07T182443.341.zip telegram-cloud-document-2-5289623460522255712.mp4 |
richard-ramos
force-pushed
the
test/extract-storenode-cycle
branch
from
598d5f2
to
f49383d
Compare
|
@pavloburykh, I just pushed a new commit with fixes for the observed issues |
44% of end-end tests have passedFailed tests (11)Click to expandClass TestFallbackMultipleDevice:
Class TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Expected to fail tests (20)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Passed tests (24)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestFallbackMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
62% of end-end tests have passedFailed tests (1)Click to expandClass TestDeepLinksOneDevice:
Expected to fail tests (20)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Passed tests (34)Click to expandClass TestFallbackMultipleDevice:
Class TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletMultipleDevice:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
|
@richard-ramos thank you for the PR. Tested and ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
This PR is a refactor that extracts the storenode cycle logic from status-go to go-waku, since this logic shouldn't be part of the application layer but from the waku layer instead.
The areas affected by this change are the message history retrieval as well as automatically choosing a storenode
cc: @pavloburykh @churik