Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: take lightclient bad peer logic from waku #21458

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

chaitanyaprem
Copy link
Contributor

@chaitanyaprem chaitanyaprem commented Oct 18, 2024

Summary

changes mentioned in waku-org/go-waku#1241
A simple logic to delete bad peers based on dial failures so that they don't get reused. this may help stabilize filter subscriptions faster.

..### Testing notes

Platforms

  • Android
  • iOS

Areas that maybe impacted

network switch
startup of app
bringing to foreground

Functional
  • 1-1 chats
  • public chats
  • group chats

Steps to test

  • Open Status
  • ...
  • Step 3, etc.

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Oct 18, 2024

Jenkins Builds

Click to see older builds (12)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 84e2db3 #1 2024-10-18 11:05:14 ~4 min tests 📄log
✔️ 84e2db3 #1 2024-10-18 11:08:48 ~8 min android-e2e 🤖apk 📲
✔️ 84e2db3 #1 2024-10-18 11:10:13 ~9 min android 🤖apk 📲
✔️ 84e2db3 #1 2024-10-18 11:10:52 ~10 min ios 📱ipa 📲
✔️ 0512114 #2 2024-10-25 08:20:11 ~6 min tests 📄log
✔️ 0512114 #2 2024-10-25 08:22:11 ~8 min android-e2e 🤖apk 📲
✔️ 0512114 #2 2024-10-25 08:24:01 ~10 min android 🤖apk 📲
✔️ 0512114 #2 2024-10-25 08:24:08 ~10 min ios 📱ipa 📲
✔️ 616fb01 #3 2024-10-29 10:57:17 ~7 min tests 📄log
✔️ 616fb01 #3 2024-10-29 11:01:01 ~10 min android-e2e 🤖apk 📲
✔️ 616fb01 #3 2024-10-29 11:01:29 ~11 min ios 📱ipa 📲
✔️ 616fb01 #3 2024-10-29 11:03:11 ~13 min android 🤖apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9592da8 #4 2024-11-05 17:59:51 ~5 min tests 📄log
✔️ 9592da8 #4 2024-11-05 18:01:47 ~7 min android-e2e 🤖apk 📲
✔️ 9592da8 #4 2024-11-05 18:04:11 ~9 min ios 📱ipa 📲
✔️ 9592da8 #4 2024-11-05 18:04:22 ~9 min android 🤖apk 📲
62264f2 #5 2024-11-09 10:39:15 ~3 min ios 📄log
✔️ 62264f2 #5 2024-11-09 10:41:11 ~5 min tests 📄log
✔️ 62264f2 #5 2024-11-09 10:42:56 ~7 min android-e2e 🤖apk 📲
✔️ 62264f2 #5 2024-11-09 10:45:42 ~9 min android 🤖apk 📲

@chaitanyaprem chaitanyaprem force-pushed the fix/filter-bad-peers branch 2 times, most recently from 0512114 to 616fb01 Compare October 29, 2024 10:49
@flexsurfer flexsurfer added status-go waku All issues relating to the Status Waku integration. labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status-go waku All issues relating to the Status Waku integration.
Projects
Status: CONTRIBUTOR
Development

Successfully merging this pull request may close these issues.

3 participants