Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix syncing screen only shows paired label after the restart #21315

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix syncing screen only shows paired label after the restart #21315

merged 1 commit into from
Oct 7, 2024

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented Sep 24, 2024 •
edited by qfrank
Loading

fixes #21259
#21260

status-go PR: status-im/status-go#5869
status-go PR: status-im/status-go#5888

status: ready

@Parveshdhull Parveshdhull self-assigned this Sep 24, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Sep 24, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (7)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ cc77364 #1 2024-09-24 08:48:13 ~6 min tests 📄log
✔️ cc77364 #1 2024-09-24 08:51:36 ~9 min android-e2e 🤖apk 📲
✔️ cc77364 #1 2024-09-24 08:53:06 ~11 min android 🤖apk 📲
✔️ cc77364 #1 2024-09-24 08:58:42 ~16 min ios 📱ipa 📲
✔️ b3bf9f5 #2 2024-09-27 10:41:30 ~5 min tests 📄log
✔️ b3bf9f5 #2 2024-09-27 10:44:48 ~9 min android-e2e 🤖apk 📲
✔️ b3bf9f5 #2 2024-09-27 10:46:09 ~10 min android 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 694b418 #3 2024-09-30 03:06:02 ~4 min tests 📄log
✔️ 694b418 #3 2024-09-30 03:09:55 ~8 min android-e2e 🤖apk 📲
✔️ 694b418 #3 2024-09-30 03:11:18 ~9 min android 🤖apk 📲
✔️ 694b418 #3 2024-09-30 03:11:30 ~10 min ios 📱ipa 📲
✔️ 4a6ae69 #4 2024-10-07 14:19:50 ~5 min tests 📄log
✔️ 4a6ae69 #4 2024-10-07 14:21:56 ~7 min android-e2e 🤖apk 📲
✔️ 4a6ae69 #4 2024-10-07 14:24:26 ~9 min android 🤖apk 📲
✔️ 4a6ae69 #4 2024-10-07 14:25:56 ~11 min ios 📱ipa 📲

@Horupa-Olena Horupa-Olena self-assigned this Sep 27, 2024
@Horupa-Olena
Copy link

@Parveshdhull Hi!
Thanks for your quick fix. Please resolved conflicts and rebase this PR.

@Parveshdhull
Copy link
Member Author

Thank you, @Horupa-Olena , for taking the PR for testing.

Thanks for your quick fix.

Actually, @qfrank is the one who fixed this issue :)

Please resolved conflicts and rebase this PR

done 👍

@qfrank qfrank mentioned this pull request Sep 30, 2024
Merged
@qfrank
Copy link
Contributor

qfrank commented Sep 30, 2024 •
edited
Loading

Hi @Horupa-Olena , pls check if this PR fixed #21259 #21260 , thank you! cc @Parveshdhull

@Horupa-Olena
Copy link

@qfrank Thanks for PR! Taking it into work!

@status-im-auto
Copy link
Member

96% of end-end tests have passed

Total executed tests: 51
Failed tests: 2
Expected to fail tests: 0
Passed tests: 49

IDs of failed tests: 702786,702844

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

    Device 2: Find `EmojisNumber` by `xpath`: `//*[starts-with(@text,'https://m.youtube.com/watch?v=Je7yErjEVt4')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-4']/android.widget.TextView[2]`
    Device 2: Element EmojisNumber text is equal to 1 

    critical/chats/test_public_chat_browsing.py:648: in test_community_links_with_previews_github_youtube_twitter_gif_send_enable
    self.errors.verify_no_errors()
base_test_case.py:192: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 No preview image is shown for https://github.com/status-im/status-mobile/pull/11707



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786

    Device 2: Getting PN by 'user_2'
    Device 2: Looking for a message by text: user_2 

    critical/chats/test_public_chat_browsing.py:962: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:192: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin



    Device sessions

    Passed tests (49)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    4. test_group_chat_pin_messages, id: 702732
    Device sessions

    5. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    6. test_group_chat_mute_chat, id: 703495
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    4. test_community_undo_delete_message, id: 702869
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    6. test_community_discovery, id: 703503
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    3. test_add_contact_field_validation, id: 702777
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links_profile, id: 702775
    Device sessions

    3. test_deep_links_communities, id: 739307
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    2. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_edit_message, id: 702855
    Device sessions

    2. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    5. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    6. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    7. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    8. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_leave, id: 702845
    Device sessions

    2. test_community_markdown_support, id: 702809
    Device sessions

    3. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    4. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    3. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    4. test_community_unread_messages_badge, id: 702841
    Device sessions

    5. test_community_message_delete, id: 702839
    Device sessions

    6. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    7. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    8. test_community_one_image_send_reply, id: 702859
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_several_images_send_reply, id: 703194
    Device sessions

    @Horupa-Olena
    Copy link

    Horupa-Olena commented Sep 30, 2024 •
    edited
    Loading

    @Parveshdhull @qfrank Hello! Thank you very much for your work. Everything works perfectly in both PRs #21259 #21260.

    I have a question regarding the Syncing tab in Settings.
    I think this is the expected result, but I need your confirmation (or correction).

    Scenario 1:

    1. Device 2 syncs with Device 1 via fallback flow.

    2. Don't confirm Pair and sync in notification in AC

    3. We go to Settings -> Sync on Device 2 (expected result?)
      photo_2024-09-30_16-07-56

    4. We go to Settings -> Sync on Device 1
      photo_2024-09-30_16-07-59

    Scenario 2:

    1. Device 2 syncs with Device 1 via the main flow twice.
    2. We go to Settings -> Sync on Device 1 (expected result?)
      photo_2024-09-30_16-08-01

    @qfrank
    Copy link
    Contributor

    qfrank commented Sep 30, 2024

    @Parveshdhull @qfrank Hello! Thank you very much for your work. Everything works perfectly in both PRs #21259 #21260.

    I have a question regarding the Syncing tab in Settings. I think this is the expected result, but I need your confirmation (or correction).

    Scenario 1:

    1. Device 2 syncs with Device 1 via fallback flow.
    2. Don't confirm Pair and sync in notification in AC
    3. We go to Settings -> Sync on Device 2 (expected result?)
      photo_2024-09-30_16-07-56
    4. We go to Settings -> Sync on Device 1
      photo_2024-09-30_16-07-59

    Scenario 2:

    1. Device 2 syncs with Device 1 via the main flow twice.
    2. We go to Settings -> Sync on Device 1 (expected result?)
      photo_2024-09-30_16-08-01

    yeah, both are expected! @Horupa-Olena

    @Horupa-Olena
    Copy link

    Horupa-Olena commented Sep 30, 2024 •
    edited
    Loading

    @qfrank Great! I don't see any issue, you can merge this PR.

    @qfrank
    Copy link
    Contributor

    qfrank commented Sep 30, 2024

    @qfrank Great! I don't see any issue, you can merge this PR.

    waiting for approval of the corresponding status-go PR @status-im/status-go-guild

    @churik
    Copy link
    Member

    churik commented Oct 7, 2024

    @qfrank please, merge the PR along with status-im/status-go#5888 (I believe it is ready already)

    We plan to check it one more time in nightly before release cut.

    Thanks!!!

    @qfrank
    Copy link
    Contributor

    qfrank commented Oct 7, 2024 •
    edited
    Loading

    @qfrank please, merge the PR along with status-im/status-go#5888 (I believe it is ready already)

    We plan to check it one more time in nightly before release cut.

    Thanks!!!

    I wish I could ... An error unrelated to the PR prevented it from merging. I'm waiting for the PR to be merged first as it will resolve the error. It should be merged days before if there's no such error @churik cc @igor-sirotin

    @qfrank qfrank force-pushed the fix/syncing-update-to-paired branch from 694b418 to 4a6ae69 Compare October 7, 2024 14:14
    @qfrank
    Copy link
    Contributor

    qfrank commented Oct 7, 2024

    going to merge it when the green merge button is ready @churik @Horupa-Olena

    @qfrank qfrank merged commit 9d3fc42 into develop Oct 7, 2024
    6 checks passed
    @qfrank qfrank deleted the fix/syncing-update-to-paired branch October 7, 2024 14:35
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @qfrank qfrank qfrank approved these changes

    @seanstrom seanstrom seanstrom approved these changes

    Assignees

    @Parveshdhull Parveshdhull

    @Horupa-Olena Horupa-Olena

    Labels
    request-manual-qa status-go Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    On the recovered device - The syncing screen only shows paired label after the restart
    6 participants
    @Parveshdhull @status-im-auto @Horupa-Olena @qfrank @churik @seanstrom