Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch gradle deps to allow other sources #21154

Closed
wants to merge 5 commits into from

Conversation

siddarthkay
Copy link
Contributor

@siddarthkay siddarthkay commented Aug 30, 2024

Summary

This PR updates patching of nodejs deps to be less aggressive when substituting the repositories with MavenLocal.
We now just append MavenLocal to the beginning of the source to allow other sources as well.
We also update the android build nix derivation to append the --offline flag only for PR and release builds.
Debug builds would need network if they are to access other sources.

Testing notes

not needed since this just impacts the way we build the android app.

Platforms

  • Android

status: ready

@siddarthkay siddarthkay self-assigned this Aug 30, 2024
@siddarthkay siddarthkay force-pushed the patch-gradle-deps-to-allow-other-sources branch from c41c57a to 5715872 Compare August 30, 2024 17:28
@status-im-auto
Copy link
Member

status-im-auto commented Aug 30, 2024

Jenkins Builds

Click to see older builds (12)
Commit #️⃣ Finished (UTC) Duration Platform Result
5715872 #2 2024-08-30 17:33:32 ~4 min android-e2e 📄log
5715872 #2 2024-08-30 17:34:23 ~5 min android 📄log
✔️ 5715872 #2 2024-08-30 17:34:48 ~5 min tests 📄log
✔️ 5715872 #2 2024-08-30 17:40:32 ~11 min ios 📱ipa 📲
17243d6 #3 2024-08-31 05:01:03 ~2 min android-e2e 📄log
17243d6 #3 2024-08-31 05:02:28 ~3 min android 📄log
✔️ 17243d6 #3 2024-08-31 05:03:54 ~4 min tests 📄log
17243d6 #3 2024-08-31 05:08:20 ~9 min ios 📄log
659c341 #4 2024-08-31 05:23:52 ~2 min android 📄log
659c341 #4 2024-08-31 05:25:43 ~4 min android-e2e 📄log
✔️ 659c341 #4 2024-08-31 05:26:05 ~5 min tests 📄log
✔️ 659c341 #4 2024-08-31 05:31:45 ~10 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
a82c91f #5 2024-09-03 06:04:29 ~2 min android 📄log
a82c91f #5 2024-09-03 06:04:30 ~2 min android-e2e 📄log
a82c91f #5 2024-09-03 06:05:20 ~3 min tests 📄log
✔️ a82c91f #5 2024-09-03 06:14:34 ~12 min ios 📱ipa 📲
992c5dc #6 2024-09-03 09:52:33 ~2 min android-e2e 📄log
992c5dc #6 2024-09-03 09:52:34 ~2 min android 📄log
992c5dc #6 2024-09-03 09:53:21 ~2 min tests 📄log
✔️ 992c5dc #6 2024-09-03 10:00:23 ~10 min ios 📱ipa 📲

@siddarthkay siddarthkay marked this pull request as draft August 30, 2024 17:35
@siddarthkay siddarthkay force-pushed the patch-gradle-deps-to-allow-other-sources branch from 5715872 to 17243d6 Compare August 31, 2024 04:58
@flexsurfer
Copy link
Member

hey @siddarthkay still relevant?

@siddarthkay
Copy link
Contributor Author

yes, no longer relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: DONE
Development

Successfully merging this pull request may close these issues.

3 participants