Patch gradle deps to allow other sources #21154
Closed
+108
−80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates patching of
nodejs
deps to be less aggressive when substituting the repositories withMavenLocal
.We now just append
MavenLocal
to the beginning of the source to allow other sources as well.We also update the android build nix derivation to append the
--offline
flag only for PR and release builds.Debug builds would need network if they are to access other sources.
Testing notes
not needed since this just impacts the way we build the android app.
Platforms
status: ready