Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix_: reloading of contacts when selected and unselected #20582

Closed
wants to merge 1 commit into from
Closed

fix_: reloading of contacts when selected and unselected #20582

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/status_im/contexts/chat/group_details/view.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
item])))))

(defn add-manage-members
[{:keys [scroll-enabled? on-scroll]}]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but we can't just remove these props? they are needed

Copy link
Contributor Author

@jo-mut jo-mut Jul 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flexsurfer do you know why we need them. I dont see why we need them on this part and scroll-enabled? is the cause for this issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is used to close the screen by scrolling, but still we need to know the reason, we can't just remove functionality

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flexsurfer the screen here will always re-render when scroll-enabled is updated and this is why scrolling stops working for a moment because its actually disabled.

I am not sure but assuming this is reason why this enabling and disabling of scroll was avoided in other areas like invite contacts to community where its the same list of contacts and the same functionality would probably be needed

[{:keys [on-scroll]}]
(let [theme (quo.theme/use-theme)
selected-participants (rf/sub [:group-chat/selected-participants])
deselected-members (rf/sub [:group-chat/deselected-members])
Expand All @@ -71,7 +71,6 @@
(i18n/label (if admin? :t/manage-members :t/add-members))]
[gesture/section-list
{:key-fn :title
:scroll-enabled @scroll-enabled?
:on-scroll on-scroll
:sticky-section-headers-enabled false
:sections (rf/sub [:contacts/grouped-by-first-letter])
Expand Down