perf!: Optimize Filter Initialization with Concurrent Processing #6106
+424
−236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (40)
|
qfrank
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6106 +/- ##
===========================================
+ Coverage 60.96% 61.04% +0.07%
===========================================
Files 814 815 +1
Lines 109253 109352 +99
===========================================
+ Hits 66611 66751 +140
+ Misses 34806 34782 -24
+ Partials 7836 7819 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ilmotta
reviewed
Nov 20, 2024
qfrank
force-pushed
the
perf/start_messenger
branch
from
478d714
to
502d4f3
Compare
igor-sirotin
approved these changes
Nov 21, 2024
ilmotta
approved these changes
Nov 22, 2024
osmaczko
approved these changes
Nov 22, 2024
qfrank
force-pushed
the
perf/start_messenger
branch
from
5a6e8db
to
7263420
Compare
|
Looks like you have BREAKING CHANGES in your PR. Check-list
|
qfrank
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes several improvements to the messenger's filter initialization and chat preview functionality:
Key Changes:
InitFiltersinto smaller, more focused functions for better maintainability, and init filters concurrentlymessenger.goto a new filemessenger_filter_init.goChatsPreviewmethodstartHistoryArchivesImportLoopThe main improvements are:
InitFiltersfunction into smaller, focused functionsThe changes maintain backward compatibility while providing new filtering capabilities for chat previews.
With this PR, the duration for api
StartMessengerhas been reduced from 1.71s to 1.02s running with iphone XS Max. Relate mobile issueWhy added ability to filter chat previews by community vs non-community chats?
Let's take a look at
chatsPreviewResponse.log, the response is very long which contains around 3.77 million characters. There's lots of chats related to community, when mobile frontend loads the chat preview list, actually it doesn't need the community chats for the chat list data soon, so we can split the long response into 2 parts(one with community chats one with non-community chats). With this solution, we can see the chat preview list almost in real time. It need wait around 2-3 seconds before this solution. But if we want to fix the performance issue totally, I'm wondering if we can useprotobufas data transfer mechanism rather thanjson🤔, you can see there's lots of string starts with0x...like0x04ffd68fe2bc7b2fceff949fd06c0f7a181ee5df2fc7ce9960c73a08e3c316a196dbae1700855a038bafe5091ab2cee9ac6fa77ed9bffe2053deeb97083d75d59f@igor-sirotin @ilmottachatsPreviewResponse.log.zip