fix(wallet)_: preserve value for token swaps to properly form path key #6058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6058 +/- ##
===========================================
- Coverage 60.87% 60.84% -0.04%
===========================================
Files 811 811
Lines 108894 108894
===========================================
- Hits 66293 66258 -35
- Misses 34843 34875 +32
- Partials 7758 7761 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
alaibe
approved these changes
Nov 7, 2024
saledjenic
reviewed
Nov 7, 2024
| @@ -164,7 +164,8 @@ func (tm *TransactionManager) buildTxForPath(path *routes.Path, pathProcessors m | |||
|
|
|||
| // special handling for transfer tx if selected token is not ETH | |||
| // TODO: we should fix that in the trasactor, but till then, the best place to handle it is here | |||
| if !path.FromToken.IsNative() { | |||
| // Paraswap needs the value to form the path key | |||
| if path.ProcessorName != pathprocessor.ProcessorSwapParaswapName && !path.FromToken.IsNative() { | |||
There was a problem hiding this comment.
@dlipicar based on what I see here we have the same issue for bridging other than ETH tokens.
There was a problem hiding this comment.
This issue started after we've added Amount to the key (under which we're storing some data for processors) to increase the uniqueness and fix the bridging issue.
Will try to think now about how to fix it globally.
|
Could we close this PR in favour of this one #6059? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value was getting set to 0 for the Paraswap processor. This would normally not be a problem since that value isn't used for actually building the transaction, but since the amount is now used to form the key in the paths map, this caused the path not to be found for swaps with input token different than ETH.
We now preserve the value.
Fixes status-im/status-mobile#21555