feat(wallet)_: store route execution data #5970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (87)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5970 +/- ##
===========================================
- Coverage 60.87% 60.84% -0.04%
===========================================
Files 811 814 +3
Lines 108894 109252 +358
===========================================
+ Hits 66293 66471 +178
- Misses 34843 34947 +104
- Partials 7758 7834 +76
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dlipicar
force-pushed
the
feat/store-route-execution-data
branch
3 times, most recently
from
1e49295
to
13e397a
Compare
dlipicar
force-pushed
the
feat/store-route-execution-data
branch
3 times, most recently
from
82ead76
to
4984280
Compare
dlipicar
force-pushed
the
feat/store-route-execution-data
branch
2 times, most recently
from
90b964e
to
f8610f5
Compare
dlipicar
force-pushed
the
feat/store-route-execution-data
branch
2 times, most recently
from
eddd7f7
to
2b16ad1
Compare
dlipicar
force-pushed
the
feat/store-route-execution-data
branch
from
2b16ad1
to
ddfcc79
Compare
saledjenic
reviewed
Nov 7, 2024
saledjenic
approved these changes
Nov 8, 2024
alaibe
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6039
Store route execution input/output data after successfully sending transactions to the chain.
This includes:
NOTE: There's certain operation that don't use the standard mechanism for sending transactions to the chain:
All these call send transactions to the chain directly and call
TrackPendingTransaction. All these operations should ideally be moved to the router, or some other standard mechanism.Also added a new db for the "PendingTxTracker". It will eventually replace the
pending_transactionstable, it's much simpler and only contains tx ID and status data. Moreover, it doesn't get removed, it retains the last state update.