Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore_: add a status proxy to the nodefleet rpc as a primary service provider #5904

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

friofry
Copy link
Contributor

@friofry friofry commented Oct 2, 2024

here is the new RPC providers call:

  • status-proxy (proxy nodefleet)
  • status-proxy-fallback (proxy infura)
  • status-proxy-fallback2 (proxy grove)
  • main (nodefleet)
  • fallback (infura)

I've tested it on the desktop using the test credentials, the rpc client works fine without falling back to other providers (unless I set the wrong credentials)

Closes #5901

As discussed on Discord, we will not be adding nodefleet (alphafleet.io) as a direct provider for now, as to not expose tokens

@status-im-auto
Copy link
Member

status-im-auto commented Oct 2, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5af4e1b #1 2024-10-02 08:26:14 ~3 min tests-rpc 📄log
✔️ 5af4e1b #1 2024-10-02 08:26:37 ~3 min linux 📦zip
✔️ 5af4e1b #1 2024-10-02 08:27:52 ~5 min android 📦aar
✔️ 5af4e1b #1 2024-10-02 08:28:18 ~5 min ios 📦zip
✖️ 5af4e1b #1 2024-10-02 08:42:02 ~19 min tests 📄log
✔️ 5af4e1b #2 2024-10-02 09:37:28 ~32 min tests 📄log

@friofry friofry requested review from alaibe and jakubgs October 2, 2024 08:31
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.11%. Comparing base (2c0178c) to head (5af4e1b).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5904      +/-   ##
===========================================
+ Coverage    45.47%   46.11%   +0.64%     
===========================================
  Files          891      891              
  Lines       158068   158076       +8     
===========================================
+ Hits         71880    72897    +1017     
+ Misses       78086    76824    -1262     
- Partials      8102     8355     +253     
Flag Coverage Δ
functional 11.85% <17.64%> (?)
unit 45.52% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/default_networks.go 99.03% <100.00%> (+0.02%) ⬆️
params/config.go 69.55% <ø> (+2.56%) ⬆️
rpc/client.go 69.13% <100.00%> (+2.88%) ⬆️
rpc/network/network.go 76.03% <100.00%> (+1.03%) ⬆️

... and 129 files with indirect coverage changes

@friofry friofry requested a review from dlipicar October 2, 2024 09:05
@friofry
Copy link
Contributor Author

friofry commented Oct 2, 2024

@jakubgs Could you please let me know when this is going to be deployed to the prod so that I can merge this PR?

Copy link
Contributor

@shivekkhurana shivekkhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@friofry friofry merged commit 66ee531 into develop Oct 2, 2024
13 checks passed
@friofry friofry deleted the ab/issue-5901-nodefleet-provider branch October 2, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from Grove to Node Fleet RPC provider
5 participants