fix_: bandwidthCounter should be reset each time it is retrieved otherwise it behaves like an accumulator #5898
+4
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-ramos
requested review from
plopezlpz,
kaichaosun,
chaitanyaprem,
igor-sirotin and
osmaczko
…rwise it behaves like an accumulator
richard-ramos
changed the title
richard-ramos
force-pushed
the
reset-bandwidth
branch
from
823db33
to
e3c5232
Compare
Jenkins Builds
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #5898 +/- ##
==========================================
Coverage ? 46.05%
==========================================
Files ? 888
Lines ? 157382
Branches ? 0
==========================================
Hits ? 72488
Misses ? 76569
Partials ? 8325
Flags with carried forward coverage won't be shown. Click here to find out more.
|
adklempner
approved these changes
Oct 1, 2024
chaitanyaprem
approved these changes
Oct 1, 2024
| go telemetry.PushProtocolStats(w.bandwidthCounter.GetBandwidthByProtocol()) | ||
| case <-ticker.C: | ||
| bandwidthPerProtocol := w.bandwidthCounter.GetBandwidthByProtocol() | ||
| w.bandwidthCounter.Reset() |
There was a problem hiding this comment.
does this mean if we want to use GetBandwidthByPeer or some other metric which uses same underlying counter, it will not work right..we will have to get all the metrics in same place and reset the counter
There was a problem hiding this comment.
Sadly yes, it is not possible to have multiple bandwidth counters
osmaczko
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding prometheus bandwidth metrics to go-waku, @AlbertoSoutullo noticed that go-waku service nodes metric value was incorrect.
This PR includes the fix that was applied to the go-waku service node