refactor_: remove generated files from source control #5878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (226)
|
igor-sirotin
force-pushed
the
chore/remove-generated-files
branch
3 times, most recently
from
3f4a08a
to
b4a27ad
Compare
|
Something's wrong when running [nix-shell:~/Repositories/Status/status-go]$ GO_GENERATE_FAST_DISABLE=1 go-generate-fast services/wallet/token/token.go
2024/09/30 11:33:46 Loading input failed: token.go:92:2: could not parse package github.com/status-im/status-go/services/wallet/token/balancefetcher: cannot find package "github.com/status-im/status-go/services/wallet/token/balancefetcher" in any of:
($GOROOT not set)
/Users/igorsirotin/go/src/github.com/status-im/status-go/services/wallet/token/balancefetcher (from $GOPATH)
running "mockgen -source=token.go -destination=mock/token/tokenmanager.go": exit status 1
services/wallet/token/token.go: mockgen -source=token.go -destination=mock/token/tokenmanager.go (error, disabled, 354ms)Same command in zsh: > GO_GENERATE_FAST_DISABLE=1 go-generate-fast services/wallet/token/token.go
services/wallet/token/token.go: mockgen -source=token.go -destination=mock/token/tokenmanager.go (generated, disabled, 2252ms)only for some of the files, not all of them. 🤔 UPD:
Line 5 in 3f7ebdb |
igor-sirotin
force-pushed
the
chore/remove-generated-files
branch
2 times, most recently
from
16c9f5e
to
3a980dd
Compare
igor-sirotin
changed the title
This was referenced Sep 30, 2024
igor-sirotin
force-pushed
the
chore/remove-generated-files
branch
from
3a980dd
to
e432591
Compare
igor-sirotin
force-pushed
the
chore/remove-generated-files
branch
3 times, most recently
from
4cf8c9e
to
064176f
Compare
igor-sirotin
force-pushed
the
chore/remove-generated-files
branch
from
064176f
to
9c5ac9b
Compare
igor-sirotin
changed the title
igor-sirotin
force-pushed
the
chore/remove-generated-files
branch
5 times, most recently
from
2a43982
to
8865560
Compare
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
igor-sirotin
force-pushed
the
chore/remove-generated-files
branch
3 times, most recently
from
c7792b0
to
1e232c1
Compare
✔️ status-go/prs/android/PR-5878#40 🔹 ~3 min 6 sec 🔹 c7792b0 🔹 📦 android package |
igor-sirotin
force-pushed
the
chore/remove-generated-files
branch
from
1e232c1
to
5becff3
Compare
igor-sirotin
force-pushed
the
chore/remove-generated-files
branch
from
c04765a
to
3f9bfb3
Compare
igor-sirotin
force-pushed
the
chore/remove-generated-files
branch
from
3f9bfb3
to
bde82a2
Compare
✔️ status-go/prs/tests/PR-5878#46 🔹 ~32 min 🔹 3f9bfb3 🔹 📦 tests package |
1 task
|
@igor-sirotin : we should probably also have |
@siddarthkay hmmm, why? 🤔 |
10 tasks
jakubgs
pushed a commit
to status-im/status-desktop
that referenced
this pull request
Oct 8, 2024
Requires things like: go-bindata mockgen protobuf Fixes: #16477 For more details see: status-im/status-go#5878 Signed-off-by: Jakub Sokołowski <[email protected]>
jakubgs
pushed a commit
to status-im/status-desktop
that referenced
this pull request
Oct 8, 2024
Requires things like: go-bindata mockgen protobuf Fixes: #16477 For more details see: status-im/status-go#5878 Signed-off-by: Jakub Sokołowski <[email protected]>
jakubgs
pushed a commit
to status-im/status-desktop
that referenced
this pull request
Oct 8, 2024
Requires things like: go-bindata mockgen protobuf Fixes: #16477 For more details see: status-im/status-go#5878 Signed-off-by: Jakub Sokołowski <[email protected]>
jakubgs
pushed a commit
to status-im/status-desktop
that referenced
this pull request
Oct 8, 2024
Requires things like: go-bindata mockgen protobuf Fixes: #16477 For more details see: status-im/status-go#5878 Signed-off-by: Jakub Sokołowski <[email protected]>
jakubgs
pushed a commit
to status-im/status-desktop
that referenced
this pull request
Oct 8, 2024
Requires things like: go-bindata mockgen protobuf Fixes: #16477 For more details see: status-im/status-go#5878 Signed-off-by: Jakub Sokołowski <[email protected]>
jakubgs
pushed a commit
to status-im/status-desktop
that referenced
this pull request
Oct 8, 2024
Requires things like: go-bindata mockgen protobuf Fixes: #16477 For more details see: status-im/status-go#5878 Signed-off-by: Jakub Sokołowski <[email protected]>
jakubgs
pushed a commit
to status-im/status-desktop
that referenced
this pull request
Oct 8, 2024
Requires things like: go-bindata mockgen protobuf Fixes: #16477 For more details see: status-im/status-go#5878 Signed-off-by: Jakub Sokołowski <[email protected]>
siddarthkay
pushed a commit
to status-im/status-desktop
that referenced
this pull request
Oct 8, 2024
Requires things like: go-bindata mockgen protobuf Fixes: #16477 For more details see: status-im/status-go#5878 Signed-off-by: Jakub Sokołowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4191
Requires:
Commits
Note
REVIEW BY COMMITS - I opened separate PRs for what was possible.
generatetargetDescription
All generated files are removed from the repo.
The only exception is
abigen-generated contracts. Makes no sense to regenerate them every time. When needed, can be done withmake generate-contracts.make generateruns generation for all subdirs (except./contracts).No need to specify the list of directories.
All required Makefile targets now have
generateas a dependant target.make generateuses go-generate-fast.Full generation takes ~20 seconds. This one has caching and takes <1 second when nothing needs to be re-generated.
On CI we ignore cache and always re-generate.