feat_: batch all telemetry data and send request every 10 seconds #5251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (46)
|
adklempner
force-pushed
the
feat/telemetry-channels
branch
from
28b4307
to
32ea02b
Compare
richard-ramos
approved these changes
Jun 5, 2024
wakuv2/telemetry.go
Outdated
| @@ -50,5 +50,7 @@ func (c *BandwidthTelemetryClient) PushProtocolStats(relayStats metrics.Stats, s | |||
| _, err := c.httpClient.Post(url, "application/json", bytes.NewBuffer(body)) | |||
| if err != nil { | |||
| c.logger.Error("Error sending message to telemetry server", zap.Error(err)) | |||
| } else { | |||
| c.logger.Debug("Successfully pushed protocol stats to telemetry server") | |||
There was a problem hiding this comment.
Might be too noisy since this is the expected result. Consider not logging this
There was a problem hiding this comment.
removed in latest commit
telemetry/client.go
Outdated
| @@ -96,5 +233,7 @@ func (c *Client) UpdateEnvelopeProcessingError(shhMessage *types.Message, proces | |||
| _, err := c.httpClient.Post(url, "application/json", bytes.NewBuffer(body)) | |||
| if err != nil { | |||
| c.logger.Error("Error sending envelope update to telemetry server", zap.Error(err)) | |||
| } else { | |||
| c.logger.Debug("Successfully pushed envelope processing error to telemetry server", zap.String("hash", types.EncodeHex(shhMessage.Hash))) | |||
There was a problem hiding this comment.
Might be too noisy due to it being the expected result. Consider not logging this
There was a problem hiding this comment.
removed in latest commit
telemetry/client.go
Outdated
| }() | ||
| } | ||
|
|
||
| func (c *Client) Start() { |
There was a problem hiding this comment.
Should we pass a context to the Start() function?
We could use it for killing the go routine once logout happens, i.e.:
select {
...
case <-ctx.Done():
return
...
}
There was a problem hiding this comment.
Added in latest commit
telemetry/client.go
Outdated
| } | ||
| } | ||
|
|
||
| func (c *Client) CollectAndProcessTelemetry() { |
There was a problem hiding this comment.
Perhaps we should accept a context here too to exit the goroutine on logout and avoid having a dangling goroutine? (The messenger should have a m.ctx context you could use)
There was a problem hiding this comment.
Added in latest commit
telemetry/client.go
Outdated
| } | ||
|
|
||
| func (c *Client) PushReceivedMessages(filter transport.Filter, sshMessage *types.Message, messages []*v1protocol.StatusMessage) { | ||
| func (c *Client) pushTelemetryRequest(request []TelemetryRequest) { | ||
| c.logger.Debug("Pushing telemetry data", zap.Any("request", request)) |
There was a problem hiding this comment.
Consider not logging this unless it's strictly necessary
There was a problem hiding this comment.
removed in latest commit
endulab
approved these changes
Jun 6, 2024
adklempner
force-pushed
the
feat/telemetry-channels
branch
6 times, most recently
from
2982f05
to
5f3eac3
Compare
adklempner
force-pushed
the
feat/telemetry-channels
branch
3 times, most recently
from
be1081a
to
60d38d2
Compare
adklempner
force-pushed
the
feat/telemetry-channels
branch
from
60d38d2
to
8582881
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of making an http request for every individual telemetric, push each to a channel and periodically batch in a single request.
A description to understand introduced changes without reading the code.
Important changes:
Closes #5240