update to devnet-4-compatible engine API #6657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etan-status
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
LGTM. the EL no longer provides requests, I think, and the libnimbus_lc function is specifically to parse, verify and expose execution data there from execution JSON-RPC. so, the depositrequests / withdrawalrequests / consolidationrequests could be removed and replaced with an api that exposes the requests hash (similar to state root / receipts root except it's not an MPT root but a random geth hash)
There was a problem hiding this comment.
ok, I want this to land asap, so I'm going to let it do that.
But follow-up PRs can handle this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.