VC: Electra fixes.

[cheatfate]

This PR includes Electra fixes for VC.
And asyncraises annotations for VC.

[github-actions]

Unit Test Results

         9 files   -        3    1 355 suites   - 455   47m 4s ⏱️ - 8m 19s
  5 227 tests ±       0    4 879 ✔️ ±       0  348 💤 ±  0  0 ❌ ±0 
21 780 runs   - 7 277  21 376 ✔️  - 7 229  404 💤  - 48  0 ❌ ±0 

Results for commit aaec8ef. ± Comparison against base commit acad28d.

♻️ This comment has been updated with latest results.

[tersec]

beacon_chain/validator_client/block_service.nim(602, 9) Hint: 'currentSlot' is declared but not used [XDeclaredButNotUsed]
beacon_chain/validator_client/block_service.nim(26, 3) Hint: 'PreparedBeaconBlock' is declared but not used [XDeclaredButNotUsed]
beacon_chain/validator_client/block_service.nim(32, 3) Hint: 'PreparedBlindedBeaconBlock' is declared but not used [XDeclaredButNotUsed]

[tersec]

beacon_chain/validator_client/block_service.nim(602, 9) Hint: 'currentSlot' is declared but not used [XDeclaredButNotUsed]
beacon_chain/validator_client/block_service.nim(26, 3) Hint: 'PreparedBeaconBlock' is declared but not used [XDeclaredButNotUsed]
beacon_chain/validator_client/block_service.nim(32, 3) Hint: 'PreparedBlindedBeaconBlock' is declared but not used [XDeclaredButNotUsed]

c881784

[etan-status]

the behaviour actually changes with deneb (https://eips.ethereum.org/EIPS/eip-7044).
As in, if it's deneb, then use the capella fork version for the exit signature, otherwise use the regular one.

[etan-status]

so, it is intended that this is a mix of capella fork version and deneb fork epoch.

[tersec]

Well, if it's Capella it can use Capella too.

nimbus-eth2/beacon_chain/spec/signatures.nim

Lines 220 to 253 in 0ecd279

	func voluntary_exit_signature_fork(
	is_post_deneb: static bool,
	state_fork: Fork,
	capella_fork_version: Version): Fork =
	when is_post_deneb:
	# Always use Capella fork version, disregarding `VoluntaryExit` epoch
	# [Modified in Deneb:EIP7044]
	Fork(
	previous_version: capella_fork_version,
	current_version: capella_fork_version,
	epoch: GENESIS_EPOCH) # irrelevant when current/previous identical
	else:
	state_fork
	func voluntary_exit_signature_fork*(
	consensusFork: static ConsensusFork,
	state_fork: Fork,
	capella_fork_version: Version): Fork =
	const is_post_deneb = (consensusFork >= ConsensusFork.Deneb)
	voluntary_exit_signature_fork(is_post_deneb, state_fork, capella_fork_version)
	func voluntary_exit_signature_fork*(
	state_fork: Fork,
	capella_fork_version: Version,
	current_epoch: Epoch,
	deneb_fork_epoch: Epoch): Fork =
	if current_epoch >= deneb_fork_epoch:
	const is_post_deneb = true
	voluntary_exit_signature_fork(
	is_post_deneb, state_fork, capella_fork_version)
	else:
	const is_post_deneb = false
	voluntary_exit_signature_fork(
	is_post_deneb, state_fork, capella_fork_version)

Nimbus is inconsistent about how it phrases this logic, but it's true, the Deneb version works too.

Either way,

if fork >= deneb:
  use capella
else:
  use real fork

and

if fork >= capella:
  use capella
else:
  use real fork

are equivalent.

[etan-status]

the difference being that within capella, capella signatures are only valid if the object's epoch is >= CAPELLA_FORK_EPOCH. while starting from deneb, the object epoch does not matter at all and can even be smth like 0.

[etan-status]

within capella, previous_version is bellatrix and current_version is capella.
from deneb onward, previous_version and `current_version are both capella.

[etan-status]

the practical implication is when trying to include a VoluntaryExit originally signed during bellatrix, but only include it lateron during Capella. (during deneb it will become invalid)

[tersec]

Ok, agree, it should be reverted.

[tersec]

6a55fda