Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add gossip validation for dc, and data column quarantine strategy #6581

Open
wants to merge 7 commits into
base: unstable
Choose a base branch
from
Open

add gossip validation for dc, and data column quarantine strategy #6581

wants to merge 7 commits into from
+383 −8

Conversation

agnxsh
Copy link
Contributor

@agnxsh agnxsh commented Sep 24, 2024

No description provided.

agnxsh
agnxsh commented Sep 24, 2024
View reviewed changes
beacon_chain/consensus_object_pools/data_column_quarantine.nim
from std/strutils import join

const
MaxDataColumns = 3 * SLOTS_PER_EPOCH * NUMBER_OF_COLUMNS
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doubt regarding MaxDataColumns, I think we should bump this number up (?)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

Unit Test Results

       12 files  +       3    1 810 suites  +455   53m 38s ⏱️ + 13m 44s
  5 227 tests +     77    4 879 ✔️ +     77  348 💤 ±  0  0 ❌ ±0 
29 057 runs  +7 532  28 605 ✔️ +7 484  452 💤 +48  0 ❌ ±0 

Results for commit 7095f66. ± Comparison against base commit 31b5c3e.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tersec tersec tersec left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agnxsh @tersec