fix stylecheck for BiggestUInt #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2024
It's a C++ backend-only phenomenon. Apparently https://github.com/status-im/nim-json-serialization/actions/runs/11107010807/job/30856615404 from last week (main It's not this PR, for sure -- I |
|
I'm guessing it's related to status-im/nim-unittest2@11f7cff @arnetheduck The |
Tried both refc and ORC, it's the same in both. And it's 100% repeatable, not a flaky memory corruption. Still investigating. But it is C++-only. With C: |
|
Opened Nim bug nim-lang/Nim#24274 |
Seems reasonable. Prefer links to upstream Nim issues so in the future it's not a mystery (yes, Less critical in test code where can just try changing something and if it works it works, but, still useful. |
|
Added comment that links to the Nim issue, is it good enough? |
Sure, yeah. Now to see if it fixes CI. |
Araq
pushed a commit
to nim-lang/Nim
that referenced
this pull request
Oct 11, 2024
fixes #24269, refs #20095 Instead of checking the package of the *used sym* to determine whether a stylecheck should trigger, we check the package of the lineinfo instead. Before #20095 this checked for the current compilation context module instead which caused issues with generic procs, but the lineinfo should more closely match the AST. I figured this might cause issues with includes etc but the foreign package test specifically tests for an include and passes, so maybe the package determining logic accounts for this already. This still might not be the correct logic, I'm not too familiar with the package handling in the compiler. Package PRs, both merged: - json_rpc: status-im/nim-json-rpc#226 - json_serialization: status-im/nim-json-serialization#99
narimiran
pushed a commit
to nim-lang/Nim
that referenced
this pull request
Oct 11, 2024
fixes #24269, refs #20095 Instead of checking the package of the *used sym* to determine whether a stylecheck should trigger, we check the package of the lineinfo instead. Before #20095 this checked for the current compilation context module instead which caused issues with generic procs, but the lineinfo should more closely match the AST. I figured this might cause issues with includes etc but the foreign package test specifically tests for an include and passes, so maybe the package determining logic accounts for this already. This still might not be the correct logic, I'm not too familiar with the package handling in the compiler. Package PRs, both merged: - json_rpc: status-im/nim-json-rpc#226 - json_serialization: status-im/nim-json-serialization#99 (cherry picked from commit aaf6c40)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in nim-lang/Nim#24269, stylecheck has a bug where it doesn't check the usage of symbols from the standard library. The tests for this library enable --styleCheck:error, so the style for stdlib symbols is fixed. In this library the only mismatching usage seems to be
BiggestUInt.