Merge remote-tracking branch 'origin/main'

statikbe · Sep 21, 2022 · 366f8f4 · 366f8f4
2 parents 15cb921 + c053f24
commit 366f8f4
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/src/Commands/SurveyheroResponseImportCommand.php b/src/Commands/SurveyheroResponseImportCommand.php
@@ -50,7 +50,7 @@ public function handle(): int
         foreach ($surveys as $survey) {
             /* @var SurveyContract $survey */
             try {
-                if($refreshResponses){
+                if ($refreshResponses) {
                     $survey->survey_last_imported = null;
                     $survey->save();
                 }

diff --git a/src/Contracts/SurveyContract.php b/src/Contracts/SurveyContract.php
@@ -27,7 +27,8 @@ public function hasResponses(): bool;
 
     /**
      * Checks if the response timestamp is more recent than the last updated survey timestamp.
-     * @param string $responseLastUpdatedIsoTimestamp
+     *
+     * @param  string  $responseLastUpdatedIsoTimestamp
      * @return bool
      */
     public function doesResponseNeedsToBeUpdated(string $responseLastUpdatedIsoTimestamp): bool;

diff --git a/src/Models/Survey.php b/src/Models/Survey.php
@@ -48,12 +48,14 @@ public function hasResponses(): bool
     }
 
     /**
-     * @inheritDoc
+     * {@inheritDoc}
      */
-    public function doesResponseNeedsToBeUpdated(string $responseLastUpdatedIsoTimestamp): bool {
-        if($this->survey_last_imported) {
+    public function doesResponseNeedsToBeUpdated(string $responseLastUpdatedIsoTimestamp): bool
+    {
+        if ($this->survey_last_imported) {
             return Carbon::parse($responseLastUpdatedIsoTimestamp)->gt($this->survey_last_imported);
+        } else {
+            return true;
         }
-        else return true;
     }
 }
diff --git a/src/Services/SurveyResponseImportService.php b/src/Services/SurveyResponseImportService.php
@@ -2,7 +2,6 @@
 
 namespace Statikbe\Surveyhero\Services;
 
-use Carbon\Carbon;
 use Illuminate\Support\Facades\DB;
 use Statikbe\Surveyhero\Contracts\SurveyContract;
 use Statikbe\Surveyhero\Contracts\SurveyResponseContract;