Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract name from functions/identifiers #348

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kopiro
Copy link

@kopiro kopiro commented Jun 1, 2023

Currently, when using function expressions or function variables in conditionals, the visualizer always shows 'Inline', even though these identifiers have a name that can be extracted.

image

@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2023

⚠️ No Changeset found

Latest commit: 674e40f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kopiro
Copy link
Author

kopiro commented Jun 1, 2023

@mattpocock

@Andarist
Copy link
Member

Thanks for the PR! I'm afraid though that we can't merge this right now. This could have unforeseen impact on some parts of the current system (an inline named function is not the same as string-named guard, like guard: 'isAdmin'). That being said, we plan to overhaul the extraction and vizualization parts and when doing so we'll address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants