-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error when updating Bard configs inside fieldsets #22
Draft
duncanmcclean
wants to merge
14
commits into
main
Choose a base branch
from
fix/updating-bard-configs-in-fieldsets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…figs-in-fieldsets
duncanmcclean
force-pushed
the
fix/updating-bard-configs-in-fieldsets
branch
from
November 12, 2024 15:46
713c00c
to
479077b
Compare
We're going to have failing tests in this PR until both statamic/cms#11096 and statamic/cms#11097 have been merged & tagged. |
…tatamic/importer into fix/updating-bard-configs-in-fieldsets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request attempts to fix an issue when imporing Bard fields where you'd get an error if the Bard field is imported from a fieldset, rather than being directly on the blueprint.
Whenever you import Bard fields, it'll enable nearly all of the available buttons in the toolbar (and create sets for blocks, if you're importing from WP's Gutenberg editor).
Since Statamic's
Blueprint::ensureFieldHasConfig()
method doesn't support ensuring imported fields, we have to manually find/update the fieldsets.Fixes #17.
Requires statamic/cms#11096.
Requires statamic/cms#11097.
To Do
BardTransformer
/Gutenberg
classesstatamic/cms