Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for referencing Assets using model ids instead of container::path ids #319

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ryanmitchell
Copy link
Contributor

@ryanmitchell ryanmitchell commented Jul 15, 2024

This PR provides a config option to reference assets by their model id, instead of their path, so in your entry data they would be stored as container_handle::model_id instead of container_handle::path_to_file.

The benefit of this approach is that when you move the file to a different location any asset references don't need to be updated, potentially removing the need for a lot of updates.

  • Write tests
  • Add update command
  • Work out how to prevent UpdateAssetReferences from running on save

@macaws
Copy link

macaws commented Nov 21, 2024

This could greatly help on a project we've been working on - hundreds of thousand of assets.

Anything I can do to help here @ryanmitchell?

@ryanmitchell
Copy link
Contributor Author

It’s waiting for @jasonvarga to give me his thoughts. It was his idea.

@ryanmitchell ryanmitchell marked this pull request as ready for review November 22, 2024 07:13
@ryanmitchell
Copy link
Contributor Author

@jasonvarga I've tidied up the outstanding issues with this and its ready for a once over if you have time. Let me know if anything needs changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants