[5.x] Increase trackDirtyStateTimeout
#10876
Open
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksleight
changed the title
trackDirtyStateTimeouttrackDirtyStateTimeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're running into an issue where large publish forms take so long to update the values after save that the dirty state timeout expires before it's finished, triggering an invalid dirty sate and leaving the publish button disabled.
This PR increases the timeout from 350 to 500ms. I know this isn't really a good long-term solution, 500ms is just another "magic number", and a different approach to managing the tracking of dirty state is probably needed, but I'm not too sure what that should be.