Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Fix github workflow for changes in JS tests #10677

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Conversation

jesseleite
Copy link
Member

@jesseleite jesseleite commented Aug 21, 2024

We figured out there was a small issue in our glob pattern for changed JS files. It used to work on JS files at the root level, but not in subdirectories.

Before:

CleanShot 2024-08-21 at 15 17 30

After:

CleanShot 2024-08-21 at 15 18 15

References #8269

@jesseleite jesseleite marked this pull request as ready for review August 21, 2024 19:19
@jasonvarga jasonvarga merged commit 46894b9 into 5.x Aug 21, 2024
15 checks passed
@jasonvarga jasonvarga deleted the fix/js-test-workflow branch August 21, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants