-
-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x] Nocache database driver #10671
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanmcclean
approved these changes
Aug 21, 2024
It might be good to enable timestamps? That way you would be able to clear regions after a given time period? Thinking about ones that are user specific. |
I'm not sure what the implementation on that could look like, but adding timestamps doesn't hurt anything. 👍 |
duncanmcclean
added a commit
to statamic/statamic
that referenced
this pull request
Oct 7, 2024
duncanmcclean
added a commit
to statamic/statamic
that referenced
this pull request
Oct 7, 2024
* Nocache database driver Related: statamic/cms#10671 * Prevent query parameters bloating the static cache Related: statamic/cms#10701 * Add entry password protection Related: statamic/cms#10800 * Fix small typo Related: statamic/cms#10824 * Move nocache js back to end of body but make configurable Related: statamic/cms#10898
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, nocache stores all of its data in the cache. Specifically an array that serves as a manifest of all the URLs that have been cached. With a lot of pages, this array could become large, and leads to high memory usage. Also if you are using redis, the large number of things in the cache can lead to high memory usage anyway.
This PR introduces a way to store it in a database instead.
To enable this:
'nocache' => 'database'
toconfig/statamic/static_caching.php
php please nocache:migration
to generate the migration file.php artisan migrate
to run the migration.php please static:clear
to clear the static cache. Things may be out of sync if you have previously cached pages but the nocache regions don't exist in the DB yet.