Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Bard: When email address is selected, assume link is a mailto #10660

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

duncanmcclean
Copy link
Member

This pull request makes a small improvement to linking email addresses in Bard.

Previously, when you had an email address selected and clicked on the "Link" button in the toolbar, it would default to a normal URL.

Now, with this PR, when you have an email address selected and click on the "Link" button, it'll default to the "Email" link type and prefill the value:

CleanShot 2024-08-19 at 18 20 42

@jasonvarga jasonvarga merged commit ae0db6e into 5.x Aug 19, 2024
16 checks passed
@jasonvarga jasonvarga deleted the bard-email-selected-assume-link-is-mailto branch August 19, 2024 17:43
@stephenmeehanuk
Copy link

This is a nice update, would it be possible to obfuscate the email address by default? Or add a config option?

At the moment it outputs email address raw <a href="mailto:[email protected]">[email protected]</a>

@duncanmcclean
Copy link
Member Author

duncanmcclean commented Sep 6, 2024

Feel free to open a feature request. Having it enabled by default might be problematic for some people, so it'll probably need to be a config option.

@stephenmeehanuk
Copy link

Done: statamic/ideas#1221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants