Add missing validator for respository resource in chart (#628)

Fixes #627

Signed-off-by: Tamal Saha <[email protected]>

chart/stash/templates/validating-webhook.yaml

@@ -57,4 +57,25 @@ webhooks:
 {{- if and (ge $major 1) (ge $minor 12) }}
   sideEffects: None
 {{- end }}
+- name: repository.admission.stash.appscode.com
+  clientConfig:
+    service:
+      namespace: default
+      name: kubernetes
+      path: /apis/admission.stash.appscode.com/v1alpha1/repositories
+    caBundle: {{ b64enc .Values.apiserver.ca }}
+  rules:
+  - operations:
+    - CREATE
+    - UPDATE
+    apiGroups:
+    - stash.appscode.com
+    apiVersions:
+    - "*"
+    resources:
+    - repositories
+  failurePolicy: Fail
+{{- if and (ge $major 1) (ge $minor 12) }}
+  sideEffects: None
+{{- end }}
 {{ end }}

pkg/controller/repository.go

@@ -40,12 +40,12 @@ func (c *StashController) NewRepositoryWebhook() hooks.AdmissionHook {
 }
 func (c *StashController) initRepositoryWatcher() {
 	c.repoInformer = c.stashInformerFactory.Stash().V1alpha1().Repositories().Informer()
-	c.repoQueue = queue.New("Repository", c.MaxNumRequeues, c.NumThreads, c.runRepositoryInjector)
+	c.repoQueue = queue.New("Repository", c.MaxNumRequeues, c.NumThreads, c.runRepositoryReconciler)
 	c.repoInformer.AddEventHandler(queue.DefaultEventHandler(c.repoQueue.GetQueue()))
 	c.repoLister = c.stashInformerFactory.Stash().V1alpha1().Repositories().Lister()
 }
 
-func (c *StashController) runRepositoryInjector(key string) error {
+func (c *StashController) runRepositoryReconciler(key string) error {
 	obj, exist, err := c.repoInformer.GetIndexer().GetByKey(key)
 	if err != nil {
 		glog.Errorf("Fetching object with key %s from store failed with %v", key, err)
@@ -61,7 +61,8 @@ func (c *StashController) runRepositoryInjector(key string) error {
 
 		if repo.DeletionTimestamp != nil {
 			if core_util.HasFinalizer(repo.ObjectMeta, util.RepositoryFinalizer) {
-				if repo.Spec.WipeOut {
+				// ignore invalid repository objects (eg: created by xray).
+				if repo.IsValid() == nil && repo.Spec.WipeOut {
 					err = c.deleteResticRepository(repo)
 					if err != nil {
 						return err