Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync secondary before lock #1945

Merged
merged 6 commits into from
Oct 4, 2023
Merged

Sync secondary before lock #1945

merged 6 commits into from
Oct 4, 2023

Conversation

sayedppqq
Copy link
Contributor

@sayedppqq sayedppqq commented Sep 26, 2023

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2023

CLA assistant check
All committers have signed the CLA.

@gitguardian
Copy link

gitguardian bot commented Sep 26, 2023

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@sayedppqq sayedppqq changed the base branch from master to release-4.4.6 September 26, 2023 13:02
@sayedppqq sayedppqq force-pushed the lock-unlock branch 2 times, most recently from 53fee3e to 025cb22 Compare September 27, 2023 05:43
Copy link
Contributor

@ArnobKumarSaha ArnobKumarSaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make a seperate file lock.go. And Move the last 5 functions of the backup.go file into that.

pkg/lock.go Show resolved Hide resolved
pkg/lock.go Outdated Show resolved Hide resolved
pkg/lock.go Show resolved Hide resolved
Signed-off-by: Arnob kumar saha <[email protected]>
@tamalsaha tamalsaha merged commit 34ab90b into release-4.4.6 Oct 4, 2023
4 checks passed
@tamalsaha tamalsaha deleted the lock-unlock branch October 4, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants