Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup default Functions & Tasks while uninstall+ refactor installer script #4

Merged
merged 9 commits into from
Jul 4, 2019
Merged

Cleanup default Functions & Tasks while uninstall+ refactor installer script #4

merged 9 commits into from
Jul 4, 2019

Conversation

hossainemruz
Copy link
Contributor

@hossainemruz hossainemruz commented Jun 12, 2019 •
edited
Loading

@hossainemruz hossainemruz requested a review from tamalsaha June 12, 2019 07:26
tamalsaha
tamalsaha reviewed Jun 20, 2019
View reviewed changes
deploy/stash.sh Outdated Show resolved Hide resolved
@hossainemruz hossainemruz changed the title Add update-status function in chart and script Delete update-status function while uninstall + refactored installer script Jul 1, 2019
@hossainemruz hossainemruz changed the title Delete update-status function while uninstall + refactored installer script Delete update-status function while uninstall + refactore installer script Jul 1, 2019
@hossainemruz hossainemruz changed the title Delete update-status function while uninstall + refactore installer script Cleanup default Functions & Tasks while uninstall+ refactor installer script Jul 1, 2019
the-redback
the-redback previously approved these changes Jul 2, 2019
View reviewed changes
tamalsaha
tamalsaha reviewed Jul 4, 2019
View reviewed changes
deploy/stash.sh Outdated Show resolved Hide resolved
tamalsaha
tamalsaha reviewed Jul 4, 2019
View reviewed changes
deploy/stash.sh Outdated
esac
fi

ARTIFACT="https://github.com/kubepack/onessl/releases/download/0.10.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we changing this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. If we need to change URL we won't need to change for every OS.
  2. Make os detection/download part reusable. If we need to download another binary in future, we would be able to reuse .
  3. Support more architecture. In future, we may need to support ARM.

@tamalsaha tamalsaha merged commit fcf2297 into master Jul 4, 2019
@tamalsaha tamalsaha deleted the add-update-status-function branch July 4, 2019 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamalsaha tamalsaha tamalsaha approved these changes

@the-redback the-redback the-redback left review comments

@suaas21 suaas21 Awaiting requested review from suaas21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hossainemruz @tamalsaha @the-redback