Fix FreeBSD cross-compilation #4251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halkeye
pushed a commit
to halkeye/stash
that referenced
this pull request
Sep 1, 2024
* Cleanup compiler container * Fix FreeBSD cross-compilation * Bump compiler version --------- Co-authored-by: WithoutPants <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes FreeBSD cross-compile support. It compiles correctly and seems to run ok in a FreeBSD VM, but proper testing from someone who actually uses FreeBSD would be greatly appreciated.
I've also cleaned up and updated the compiler container, shaving down its size from 6.08GB to 4.39GB despite the additional FreeBSD libs.
Most of the changes were taken from https://github.com/smartmontools/docker-build.
Supersedes #4249