Log more when resolving Python #4185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users often have problems configuring their Python installations
Adds additional logging to plugin tasks to align with the logging that scrapers output.
Maista6969
force-pushed
the
better-python-errmsg
branch
from
8b38b16 to
109202e
Compare
WithoutPants
requested changes
Oct 16, 2023
pkg/scraper/script.go
Outdated
Comment on lines
91
to
87
| logger.Debugf("Scraper script <%s> started", strings.Join(cmd.Args, " ")) | ||
| logger.Infof("Scraper script <%s> started", strings.Join(cmd.Args, " ")) |
There was a problem hiding this comment.
I don't think this is necessary.
There was a problem hiding this comment.
Changing the level or logging that the scraper script is running? This was mostly for the support cases were we get "ran the scraper, nothing in the log" and I think it'd be helpful to at least see that Stash ran the scraper successfully even if it didn't produce correct output. We always ask users to turn their logging level to Debug and then there's usually some output 🙂
pkg/scraper/script.go
Outdated
Comment on lines
119
to
115
| logger.Debugf("Scraper script finished") | ||
| logger.Infof("Scraper script finished") |
WithoutPants
approved these changes
Nov 21, 2023
halkeye
pushed a commit
to halkeye/stash
that referenced
this pull request
Sep 1, 2024
* Log more when resolving Python Users often have problems configuring their Python installations * Convert if-else ladder to switch statement * Consolidate Python resolution Adds additional logging to plugin tasks to align with the logging that scrapers output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's very common for users to struggle with configuring their Python environment for use with Stash and more verbose logging will help us when diagnosing the common issue of not knowing which (if any) Python executable they are using.
I also think the
Resolvemethod could use the result ofLookPathdirectly to use the absolute path for the Python executables it might find: this should make no difference to its usage, but allows us to log the absolute path.