Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last part of my model refactoring, mainly focusing on repositories:
manager.Repository
in favour of justmodels.Repository
, and some cleanup around uses oftxn.WithTxn
and unnecessaryRepository
ortxn.Manager
function arguments or struct fields.models.TxnManager
to the various otherRepository
structs, and addsNewRepository
functions to easily create those repositories from amodels.Repository
. Also more cleanup around usage of those repositories.Database
struct for the entire database, which makes it easier to create and use the mockReaderWriter
s.AssertExpectations
utility method to the mockDatabase
, which just callsAssertExpectations
on all theReaderWriter
s.routes
struct, adding a utilitywithReadTxn
method for use with a request context.models
tointernal/static
, and adds exported convenience functions tointernal/static
which panic if reading fails, since this should never happen.internal/api/images.go
.