Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scene scraper movie error #3633

Merged
merged 2 commits into from
May 3, 2023
Merged

Fix scene scraper movie error #3633

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
706e822
fix scene scraper movie error
dogwithakeyboard Apr 2, 2023
1f2993f
Merge branch 'stashapp:develop' into movie-maker
dogwithakeyboard Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ui/v2.5/src/components/Scenes/SceneDetails/SceneScrapeDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@ export const SceneScrapeDialog: React.FC<ISceneScrapeDialogProps> = ({

// remove the movie from the list
const newMoviesClone = newMovies.concat();
const pIndex = newMoviesClone.indexOf(toCreate);
const pIndex = newMoviesClone.findIndex((p) => p.name === toCreate.name);
if (pIndex === -1) throw new Error("Could not find movie to remove");
newMoviesClone.splice(pIndex, 1);

Expand Down Expand Up @@ -558,7 +558,7 @@ export const SceneScrapeDialog: React.FC<ISceneScrapeDialogProps> = ({
// remove the tag from the list
const newTagsClone = newTags.concat();
const pIndex = newTagsClone.indexOf(toCreate);
if (pIndex === -1) throw new Error("Could not find performer to remove");
if (pIndex === -1) throw new Error("Could not find tag to remove");
newTagsClone.splice(pIndex, 1);

setNewTags(newTagsClone);
Expand Down