titleDiff plugin #77
Open
titleDiff plugin #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnkai
reviewed
Nov 2, 2022
Comment on lines
+30
to
+31
| var filename = scenes[i].path.split(/.*[\/|\\]/)[1]; | ||
| var filenameNoExt = filename.replace(/\.[^/.]+$/, "") |
There was a problem hiding this comment.
Can you add an extra check for future proofing here?
With the stashapp/stash#3006 PR there can be scenes with no files. For those the path is empty and thus you get Plugin returned error: TypeError: Cannot access member 'replace' of undefined and the plugin exits. For those cases i think just skipping the scene is ok
|
@o-fl0w , you still around? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin with a task. When ran tags all scenes where title differs from filename (with or without extension).