Updates TPDBMarkers to allow tag and title changes. #429
+193
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or to the title, also allows running on scenes with existing markers. Fixes a bug in process all that caused some scenes to not be processed due to rounding.
Ran Black formatter.
|
please rebase to exclude timestamp.trade changes and delete or ignore your .idea folder |
|
@Tweeticoats Do you want me to update this PR or are you going to integrate into upcoming TPDBMarkers changes? |
|
You can update it if you want, it's still on my list of things to do if you don't |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates TPDBMarkers to have options for adding [TPDBMarker] as a tag or to the title, also allows running on scenes with existing markers.
Fixes a bug in processAll that caused some scenes to not be processed due to rounding.
The same as the TimestampTrade pull request.