Issue #145 #146
Merged
Issue #145 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 12, 2024 11:20
|
Check if destination is a date. If it is then should:
|
kevarding
reviewed
Jun 18, 2024
| if isinstance(input_data, datetime.datetime): | ||
| input_data = str(input_data).replace(' ', '_') | ||
| warnings.warn( | ||
| f"Found destination with a datetime format ({str(input_data)}). " \ |
There was a problem hiding this comment.
I wonder if at this point input_data is not already a str with white space replaced by underscore? This would make the warning a little confusing.
I would suggest to not reassign input_data but rather create a new variable result (or whatever name you prefer) to be able to report on the original data.
There was a problem hiding this comment.
yeap, nice catch, thanks:)
kevarding
reviewed
Jun 18, 2024
| typing-extensions | ||
| pyarrow |
There was a problem hiding this comment.
I wonder why we did not need pyarrow in the requirements before?
There was a problem hiding this comment.
I just have changed the order to have the same as we have in the requirements_pandas1.txt file.
kevarding
reviewed
Jun 18, 2024
kevarding
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving issue #145