Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(fee): add code to l2 cost #461

Conversation

nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Aug 14, 2024

This change is Reviewable

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.86%. Comparing base (ea8a494) to head (d3c34bb).

Files with missing lines Patch % Lines
crates/blockifier/src/transaction/objects.rs 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                              Coverage Diff                              @@
##           nimrod/l2_gas/calldata_and_signature_cost     #461      +/-   ##
=============================================================================
- Coverage                                      70.87%   70.86%   -0.01%     
=============================================================================
  Files                                             85       85              
  Lines                                          11023    11020       -3     
  Branches                                       11023    11020       -3     
=============================================================================
- Hits                                            7812     7809       -3     
+ Misses                                          2822     2821       -1     
- Partials                                         389      390       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from 9678b45 to 1c12f1d Compare September 1, 2024 06:00
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from 1c12f1d to 77925d7 Compare September 1, 2024 08:17
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from 77925d7 to 014a7b6 Compare September 1, 2024 11:00
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from 014a7b6 to b90b768 Compare September 3, 2024 06:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from b90b768 to df18d94 Compare September 3, 2024 13:43
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from df18d94 to b1a83bb Compare September 3, 2024 13:46
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from b1a83bb to 40c1736 Compare September 3, 2024 13:52
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from 40c1736 to 8e17973 Compare September 3, 2024 15:18
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from 8e17973 to 605fcc5 Compare September 4, 2024 06:39
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from 605fcc5 to 019b564 Compare September 4, 2024 07:05
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from 019b564 to 93b2535 Compare September 4, 2024 11:07
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from 93b2535 to f7fa5ae Compare September 4, 2024 11:10
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from f7fa5ae to 8219d75 Compare September 4, 2024 13:38
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from 8219d75 to b16ec40 Compare September 5, 2024 07:18
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/calldata_and_signature_cost branch from b16ec40 to ea8a494 Compare September 5, 2024 11:10
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant