-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(transaction): add clone to declare tx #33
Conversation
fix(format): run format fix on all repo
chore: sync repos
chore: add committer
Signed-off-by: Dori Medini <[email protected]>
* feature(ci): Identify which package need to be built according to file changed --------- Signed-off-by: Dori Medini <[email protected]> Co-authored-by: Dori Medini <[email protected]>
Signed-off-by: Dori Medini <[email protected]>
* chore: fix ci to always compare changes against the target branch
* chore: copy all crates * chore: switch to local dependencies * chore: delete old papyrus_test_utils crate * chore: rename crate test_utils -> papyrus_test_utils * chore: fix RPCTransactio name in the mempool * chore: fix mockito deps in papyrus and gateway * chore: update cairo-* deps version * chore: update config and presets for mempool and papyrus * chore: rename default_config.json -> papyrus_default_config.json * chore: rustfmt * chore: reorg folders * chore: reorg folders * chore: fix unused deps * chore: update papyrus Dockerfile * chore: update scripts folder * chore: copy build_native_blockifier.sh * chore: copy BUILD and WORKSPACE files (from blockifier and committer) * chore: update papyrus non crates folders and files * chore: copy blockifier docs * chore: copy committer taplo.toml * chore: fix config tests * chore: copy blockifier docker file * fix: papyrus integration test runs only Papyrus related tests * chore: rename conflicting dump_config.rs files * chore: fix cargo doc errors * chore: fix CI * chore: small optimizations for the papyrus CI * chore: copy README files * chore: meld common repo files --------- Co-authored-by: alon.dotan <[email protected]> Co-authored-by: Dan Brownstein <[email protected]>
Signed-off-by: Dori Medini <[email protected]>
Co-Authored-By: alon.dotan <[email protected]>
The author of this PR, meship-starkware, is not an activated member of this organization on Codecov. |
d72c549
to
3d8a56b
Compare
3d8a56b
to
bcae9d9
Compare
You made this change in #34 as well. Code quote: Collector::new(PROCESS_METRICS_PREFIX).collect(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 4 files at r1, all commit messages.
Reviewable status: 2 of 4 files reviewed, 2 unresolved discussions (waiting on @avi-starkware and @meship-starkware)
crates/blockifier/src/transaction/account_transaction.rs
line 66 at r1 (raw file):
/// Represents a paid Starknet transaction. #[derive(Debug, Clone)]
Please keep it alphabetical (relevant to all changes made in this PR).
Code quote:
#[derive(Debug, Clone)]
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information
This change is