Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transaction): add clone to declare tx #33

Closed
wants to merge 25 commits into from

Conversation

meship-starkware
Copy link
Contributor

@meship-starkware meship-starkware commented Jul 23, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

dafnamatsry and others added 24 commits May 2, 2024 14:06
fix(format): run format fix on all repo
* feature(ci): Identify which package need to be built according to file changed
---------

Signed-off-by: Dori Medini <[email protected]>
Co-authored-by: Dori Medini <[email protected]>
* chore: fix ci to always compare changes against the target branch
* chore: copy all crates

* chore: switch to local dependencies

* chore: delete old papyrus_test_utils crate

* chore: rename crate test_utils -> papyrus_test_utils

* chore: fix RPCTransactio name in the mempool

* chore: fix mockito deps in papyrus and gateway

* chore: update cairo-* deps version

* chore: update config and presets for mempool and papyrus

* chore: rename default_config.json -> papyrus_default_config.json

* chore: rustfmt

* chore: reorg folders

* chore: reorg folders

* chore: fix unused deps

* chore: update papyrus Dockerfile

* chore: update scripts folder

* chore: copy build_native_blockifier.sh

* chore: copy BUILD and WORKSPACE files (from blockifier and committer)

* chore: update papyrus non crates folders and files

* chore: copy blockifier docs

* chore: copy committer taplo.toml

* chore: fix config tests

* chore: copy blockifier docker file

* fix: papyrus integration test runs only Papyrus related tests

* chore: rename conflicting dump_config.rs files

* chore: fix cargo doc errors

* chore: fix CI

* chore: small optimizations for the papyrus CI

* chore: copy README files

* chore: meld common repo files

---------

Co-authored-by: alon.dotan <[email protected]>
Co-authored-by: Dan Brownstein <[email protected]>
Copy link

codecov bot commented Jul 23, 2024

The author of this PR, meship-starkware, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at [email protected] with any questions.

@meship-starkware meship-starkware changed the title fix(transactions): add clone to declare tx fix(transaction): add clone to declare tx Jul 23, 2024
@meship-starkware meship-starkware changed the base branch from main-v0.13.2 to main July 23, 2024 12:06
@meship-starkware meship-starkware requested review from avi-starkware and removed request for dan-starkware July 23, 2024 12:07
@avi-starkware
Copy link
Contributor

crates/papyrus_monitoring_gateway/src/lib.rs line 316 at r1 (raw file):

    match prometheus_handle {
        Some(handle) => {
            Collector::new(PROCESS_METRICS_PREFIX).collect();

You made this change in #34 as well.
Let's just make this change in another PR that we can merge immediately.

Code quote:

            Collector::new(PROCESS_METRICS_PREFIX).collect();

Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 4 files at r1, all commit messages.
Reviewable status: 2 of 4 files reviewed, 2 unresolved discussions (waiting on @avi-starkware and @meship-starkware)


crates/blockifier/src/transaction/account_transaction.rs line 66 at r1 (raw file):

/// Represents a paid Starknet transaction.
#[derive(Debug, Clone)]

Please keep it alphabetical (relevant to all changes made in this PR).

Code quote:

#[derive(Debug, Clone)]

@liorgold2 liorgold2 closed this Jul 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2024
@meship-starkware meship-starkware deleted the meship/add_clone_to_declare_tx branch July 28, 2024 07:52
@meship-starkware meship-starkware restored the meship/add_clone_to_declare_tx branch July 28, 2024 07:59
@meship-starkware meship-starkware deleted the meship/add_clone_to_declare_tx branch July 28, 2024 08:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants