-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blockifier): add impl for GasCosts in versioned_constants #2067
base: main
Are you sure you want to change the base?
Conversation
Artifacts upload triggered. View details here |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2067 +/- ##
==========================================
- Coverage 74.18% 68.85% -5.34%
==========================================
Files 359 105 -254
Lines 36240 13700 -22540
Branches 36240 13700 -22540
==========================================
- Hits 26886 9433 -17453
+ Misses 7220 3864 -3356
+ Partials 2134 403 -1731
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @avi-starkware and @Yonatan-Starkware)
crates/blockifier/src/versioned_constants.rs
line 592 at r1 (raw file):
pub fn get_builtin_gas_cost(&self, builtin: &BuiltinName) -> u64 { match *builtin { BuiltinName::output => 0,
Please locate all zeros at the end and document them
segment_arena - it's a virtual builtin.
output - not relevant for smart contract.
The rest are not supported for cairo 1
crates/blockifier/src/versioned_constants.rs
line 631 at r1 (raw file):
SyscallSelector::StorageRead => self.storage_read_gas_cost, SyscallSelector::StorageWrite => self.storage_write_gas_cost, _ => 0,
Please list all cases explicitly (we don't like default, it could hide bugs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Yonatan-Starkware)
No description provided.