Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(batcher): add abort to the proposal manager #2060

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dafnamatsry
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

dafnamatsry commented Nov 14, 2024

@dafnamatsry dafnamatsry marked this pull request as ready for review November 14, 2024 11:54
@dafnamatsry dafnamatsry force-pushed the 11-14-feat_batcher_add_abort_to_the_proposal_manager branch from a2c923b to 1054fbc Compare November 14, 2024 11:54
@dafnamatsry dafnamatsry force-pushed the 11-14-feat_batcher_add_abort_to_the_proposal_manager branch from 1054fbc to 9fef699 Compare November 14, 2024 12:17
@dafnamatsry dafnamatsry force-pushed the 11-14-feat_batcher_add_abort_to_the_proposal_manager branch from 9fef699 to a998bab Compare November 14, 2024 14:46
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 61.76471% with 13 lines in your changes missing coverage. Please review.

Project coverage is 5.08%. Comparing base (e3165c4) to head (a998bab).
Report is 402 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_batcher/src/proposal_manager.rs 63.63% 5 Missing and 7 partials ⚠️
crates/starknet_batcher/src/batcher.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2060       +/-   ##
==========================================
- Coverage   40.10%   5.08%   -35.03%     
==========================================
  Files          26     141      +115     
  Lines        1895   16865    +14970     
  Branches     1895   16865    +14970     
==========================================
+ Hits          760     857       +97     
- Misses       1100   15937    +14837     
- Partials       35      71       +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants