fix(ci): make upload artifacts job edit the comment #2054
Conversation
|
This change is |
|
Artifacts upload triggered. View details here |
|
Artifacts upload triggered. View details here |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| body: `Artifacts upload triggered. [View details here](${workflowLink})` | ||
| }) | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| issue-number: ${{ process.env.PR_NUMBER }} |
There was a problem hiding this comment.
The environment variable reference should be ${{ env.PR_NUMBER }} instead of ${{ process.env.PR_NUMBER }}. GitHub Actions workflow syntax uses env directly to access environment variables, while process.env is Node.js syntax that won't work in this context.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
Done.
| @@ -213,6 +213,7 @@ impl BlockContext { | |||
| } | |||
| } | |||
|
|
|||
| // tmp | |||
There was a problem hiding this comment.
This comment // tmp appears to be unrelated to the CI changes in this PR and was likely committed accidentally. Please remove it in a separate commit or PR.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2054 +/- ##
===========================================
+ Coverage 40.10% 69.00% +28.89%
===========================================
Files 26 103 +77
Lines 1895 13562 +11667
Branches 1895 13562 +11667
===========================================
+ Hits 760 9358 +8598
- Misses 1100 3804 +2704
- Partials 35 400 +365 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Dori Medini <[email protected]>
Signed-off-by: Dori Medini <[email protected]>
dorimedini-starkware
force-pushed
the
dori/upload-artifacts-edit-comment
branch
from
b8d42f2
to
f250d76
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @graphite-app[bot])
| body: `Artifacts upload triggered. [View details here](${workflowLink})` | ||
| }) | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| issue-number: ${{ process.env.PR_NUMBER }} |
There was a problem hiding this comment.
Done.
|
Artifacts upload triggered. View details here |
No description provided.