Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(network): broadcast stress test #2025

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

eitanm-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

Artifacts upload triggered. View details here

Copy link

Artifacts upload triggered. View details here

Copy link

Artifacts upload triggered. View details here

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0.60241% with 165 lines in your changes missing coverage. Please review.

Project coverage is 76.84%. Comparing base (e3165c4) to head (77ad5e4).
Report is 404 commits behind head on main.

Files with missing lines Patch % Lines
...pyrus_network/src/bin/network_stress_test/utils.rs 0.00% 83 Missing ⚠️
...apyrus_network/src/bin/network_stress_test/main.rs 0.00% 73 Missing ⚠️
..._network/src/bin/network_stress_test/converters.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2025       +/-   ##
===========================================
+ Coverage   40.10%   76.84%   +36.73%     
===========================================
  Files          26      377      +351     
  Lines        1895    39990    +38095     
  Branches     1895    39990    +38095     
===========================================
+ Hits          760    30729    +29969     
- Misses       1100     6978     +5878     
- Partials       35     2283     +2248     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Artifacts upload triggered. View details here

Comment on lines 36 to 38
let vec_size = value.len();
let payload_size = vec_size - 12;
let payload_size = vec_size - METADATA_SIZE;
let id_and_time = value.split_off(payload_size);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message parsing code should validate that value.len() >= METADATA_SIZE before attempting to split the message. This prevents panics from malformed messages. Consider adding:

if value.len() < METADATA_SIZE {
    return Err(NetworkError::InvalidMessageFormat);
}

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Copy link

Artifacts upload triggered. View details here

Copy link

Artifacts upload triggered. View details here

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.502 ms 34.707 ms 34.978 ms]
change: [-4.1773% -2.5308% -1.0323%] (p = 0.00 < 0.05)
Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
2 (2.00%) high mild
9 (9.00%) high severe

Copy link

Artifacts upload triggered. View details here

Copy link

Artifacts upload triggered. View details here

Copy link

Artifacts upload triggered. View details here

Copy link

Artifacts upload triggered. View details here

Copy link

Artifacts upload triggered. View details here

Copy link

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [30.517 ms 30.599 ms 30.713 ms]
change: [+2.1642% +2.4924% +2.9377%] (p = 0.00 < 0.05)
Performance has regressed.
Found 5 outliers among 100 measurements (5.00%)
3 (3.00%) high mild
2 (2.00%) high severe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants