Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename dirs to reflect their crate name #1994

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

ShahakShama
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@ShahakShama ShahakShama force-pushed the shahak/rename_dirs_according_to_crate_name branch from 789ea45 to c25546a Compare November 12, 2024 15:16
Copy link

Artifacts upload triggered. View details here

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.48%. Comparing base (e3165c4) to head (24379d9).
Report is 345 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1994       +/-   ##
===========================================
+ Coverage   40.10%   76.48%   +36.38%     
===========================================
  Files          26      373      +347     
  Lines        1895    39965    +38070     
  Branches     1895    39965    +38070     
===========================================
+ Hits          760    30568    +29808     
- Misses       1100     7121     +6021     
- Partials       35     2276     +2241     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShahakShama ShahakShama force-pushed the shahak/rename_dirs_according_to_crate_name branch from c25546a to 1b1335f Compare November 12, 2024 15:44
Copy link

Artifacts upload triggered. View details here

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 154 of 158 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

@ShahakShama ShahakShama force-pushed the shahak/rename_dirs_according_to_crate_name branch from 1b1335f to fad771d Compare November 13, 2024 06:45
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

Copy link

Artifacts upload triggered. View details here

@ShahakShama ShahakShama force-pushed the shahak/rename_dirs_according_to_crate_name branch from fad771d to 24379d9 Compare November 13, 2024 07:12
Copy link

Artifacts upload triggered. View details here

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

@ShahakShama ShahakShama merged commit 87b728f into main Nov 13, 2024
21 checks passed
@ShahakShama ShahakShama deleted the shahak/rename_dirs_according_to_crate_name branch November 13, 2024 07:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants