test(mempool_p2p): test tx received from p2p reach mempool

[AlonLStarkWare]

• chore: derive Hash on RpcTransaction
• chore: changing closure Fn requirements on integration test utils
• test(mempool_p2p): test received rpc transactions are being broadcasted
• test(mempool_p2p): test tx received from p2p reach mempool

[reviewable-StarkWare]

This change is 

[graphite-app]

Typo in comment: becuase -> because

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

[AlonLStarkWare]

👍

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.08%. Comparing base (e3165c4) to head (0b0ec55).
Report is 375 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1990      +/-   ##
==========================================
- Coverage   40.10%   34.08%   -6.03%     
==========================================
  Files          26      267     +241     
  Lines        1895    30966   +29071     
  Branches     1895    30966   +29071     
==========================================
+ Hits          760    10554    +9794     
- Misses       1100    19440   +18340     
- Partials       35      972     +937     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[AlonLStarkWare]

Reviewable status: 0 of 12 files reviewed, 1 unresolved discussion (waiting on @graphite-app[bot] and @ShahakShama)

[AlonLStarkWare]

👍

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[ShahakShama]

Reviewed 1 of 8 files at r4, 4 of 5 files at r6, 1 of 7 files at r8, 6 of 6 files at r9, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @AlonLStarkWare)

---

crates/starknet_integration_tests/tests/mempool_p2p_flow_test.rs line 136 at r9 (raw file):

#[tokio::test]
async fn test_mempool_receives_tx_from_other_peer(tx_generator: MultiAccountTransactionGenerator) {
    let handle = Handle::current();

Remove code dup with other test by defining a setup function in this module (it can be private)

---

crates/starknet_integration_tests/tests/mempool_p2p_flow_test.rs line 205 at r9 (raw file):

    }

    // waiting for the tx to be received (TODO: figure out a better solution)

You can iteratively call get_txs with a sleep of much lower time until you get expected_txs.len() txs
Fail if you passed x iterations (calculate x so that the time it will take is 2 seconds)

---

crates/starknet_integration_tests/tests/mempool_p2p_flow_test.rs line 208 at r9 (raw file):

    tokio::time::sleep(std::time::Duration::from_millis(2000)).await;

    let received_tx = mempool_client.get_txs(expected_txs.len()).await.unwrap();

received_txs

---

crates/starknet_integration_tests/tests/mempool_p2p_flow_test.rs line 213 at r9 (raw file):

    assert_eq!(received_tx.len(), expected_txs.len());

    for tx in received_tx.iter() {

No need to write iter here. Surprised clippy and graphite-bot didn't say anything

---

crates/starknet_integration_tests/tests/mempool_p2p_flow_test.rs line 214 at r9 (raw file):

    for tx in received_tx.iter() {
        let converted_tx: RpcTransaction = match tx {

Add TODO to change mempool to store RpcTransaction