refactor(blockifier): account_tx from enum to struct w api::executable_tx

[avivg-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [32.534 ms 32.665 ms 32.800 ms]
change: [-4.5625% -2.7976% -1.2002%] (p = 0.00 < 0.05)
Performance has improved.

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[codecov]

Codecov Report

Attention: Patch coverage is 62.90323% with 46 lines in your changes missing coverage. Please review.

Project coverage is 46.84%. Comparing base (e3165c4) to head (038d7b3).
Report is 316 commits behind head on main.

Files with missing lines	Patch %	Lines
...lockifier/src/transaction/transaction_execution.rs	9.09%	20 Missing ⚠️
.../blockifier/src/transaction/account_transaction.rs	78.87%	15 Missing ⚠️
crates/native_blockifier/src/py_transaction.rs	0.00%	8 Missing ⚠️
crates/native_blockifier/src/py_declare.rs	0.00%	1 Missing ⚠️
crates/native_blockifier/src/py_deploy_account.rs	0.00%	1 Missing ⚠️
crates/native_blockifier/src/py_invoke_function.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1688      +/-   ##
==========================================
+ Coverage   40.10%   46.84%   +6.73%     
==========================================
  Files          26      222     +196     
  Lines        1895    25593   +23698     
  Branches     1895    25593   +23698     
==========================================
+ Hits          760    11988   +11228     
- Misses       1100    12810   +11710     
- Partials       35      795     +760     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[meship-starkware]

Reviewed 12 of 14 files at r12.
Reviewable status: 27 of 29 files reviewed, 3 unresolved discussions (waiting on @avivg-starkware and @noaov1)

[meship-starkware]

Reviewed 2 of 14 files at r12, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @avivg-starkware and @noaov1)

[avivg-starkware]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noaov1)

---

crates/blockifier/src/transaction/account_transaction.rs line 87 at r9 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Can this be public? If so, consider removing the new and new_for_query methods.

Yes, will take care in a separate PR

---

crates/blockifier/src/transaction/account_transaction.rs line 100 at r9 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Consider moving some of the logic (e.g. the match) to the Transaction enum in starknet api.

Sounds good, adding a todo, to consider this change separately.

---

crates/blockifier/src/transaction/account_transaction.rs line 131 at r9 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Consider moving this logic to starknet api
Applies to all the getters methods in this file.
(can be done in a separate PR)

Will address in a separate PR

some elaboration: I was considering doing so ( for each fn it's slightly different and there wasn't any simple conversion that worked for all).
I chose to keep it simple for now to make all changes here easier to follow.

[github-actions]

Artifacts upload triggered. View details here

[noaov1]

Reviewed 1 of 2 files at r13, all commit messages.
Reviewable status: 28 of 29 files reviewed, all discussions resolved (waiting on @meship-starkware)

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[avivg-starkware]

Reviewed 5 of 24 files at r3, 2 of 7 files at r4, 1 of 12 files at r5, 1 of 6 files at r6, 3 of 6 files at r7, 3 of 14 files at r10, 12 of 14 files at r12, 2 of 2 files at r13, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

all addressed. approved verbally. Noa on days off