Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dev into production #1696

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Merge dev into production #1696

merged 2 commits into from
Nov 23, 2023

Conversation

github-actions[bot]
Copy link

How to approve and merge this pull request

As a content contributor, follow these steps to review, approve, and merge this pull request:

  • 1. Review the changes made in this pull request by looking at the "Files changed" tab. Make sure everything looks correct and as expected.
  • 2. Visit the live preview of the changes at https://starknet-website-dev.vercel.app/. Ensure the changes are properly implemented and everything is working as expected.
  • 3. If you are satisfied with the changes, click on the "Review changes" button (usually green) at the top of the pull request page.
  • 4. In the review summary dialog, select "Approve" and click on "Submit review."

💡 Remember, you cannot fully approve your own changes. Content reviewers can approve each other's changes, and if only content has changed, a developer is not required to approve. Mention a colleague using their GitHub username (e.g., @username) in the PR comments or directly communicate with them to request their review.

  • 5. After receiving approval from another team member, click on the "Merge pull request" button.
  • 6. Optionally, you can add a comment before merging.
  • 7. Click on "Confirm merge" to finalize the process. The changes will be applied to the production branch, and starknet.io will be updated within a few minutes.

If you are unsure about merging something or need any assistance, please ping a developer to double check.

@nuno-aac nuno-aac merged commit c1bf42d into production Nov 23, 2023
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants