Merge pull request #1857 from starknet-io/enhancement/seo-lang-h1

SEO tasks #2
starknet-io · Dec 19, 2023 · 3dfa166 · 3dfa166
2 parents c01889e + beed0cf
commit 3dfa166
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/workspaces/website/src/pages/posts/PostByCategory.tsx b/workspaces/website/src/pages/posts/PostByCategory.tsx
@@ -101,7 +101,7 @@ export default function PostByCategory({
               {post.post_type}
             </Badge>
           </Box>
-          <Heading variant="h2" color="heading-navy-fg" fontWeight="extrabold">
+          <Heading as="h1" variant="h2" color="heading-navy-fg" fontWeight="extrabold">
             {post.title}
           </Heading>
           <Flex mt="16px">
@@ -154,4 +154,4 @@ export default function PostByCategory({
       }
     />
   );
-}
+}
diff --git a/workspaces/website/src/pages/roadmap/@slug/(components)/RoadmapPost.tsx b/workspaces/website/src/pages/roadmap/@slug/(components)/RoadmapPost.tsx
@@ -117,7 +117,7 @@ export default function RoadmapPost({
           <Box mb={"2rem"}>
             <RoadmapPostVersion roadmapVersion={roadmapVersion} />
           </Box>
-          <Heading variant="h2" color="heading-navy-fg" fontWeight="extrabold">
+          <Heading as="h1" variant="h2" color="heading-navy-fg" fontWeight="extrabold">
             {roadmapPost.title}
           </Heading>
           <Flex direction="row" alignItems="center" mt="6" mb="32px" justifyContent="space-between">
@@ -131,7 +131,7 @@ export default function RoadmapPost({
             <div>{roadmapPost?.state ? <Text display="flex" alignItems="center" variant="cardBody" color="roadmap-availability-state-fg" height="32px" borderRadius="5px" padding="4px 12px" borderWidth="1px" borderStyle="solid" borderColor="roadmap-card-border-color" bg="roadmap-card-tag-bg">{roadmapPost?.state}<Box display="inline-block" bg={roadmapPost?.state === "On testnet" ? "#00815C" : "#EF5600"} borderRadius="50%" width="14px" height="14px" ml="2"></Box></Text> : null}</div>
           </Flex>
           <Divider mt="8px" mb="32px" />
-          
+
           <Flex direction="column" gap="32px">
             {roadmapPost.blocks?.map((block, i) => (
               <Block

diff --git a/workspaces/website/src/renderer/_default.page.server.tsx b/workspaces/website/src/renderer/_default.page.server.tsx
@@ -1,6 +1,6 @@
 import { renderToStream } from "react-streaming/server";
 import { escapeInject } from "vite-plugin-ssr/server";
-import { DocumentProps, PageContextServer, SeoType } from "./types";
+import { PageContextServer, SeoType } from "./types";
 import { PageShell } from "./PageShell";
 import { getDefaultPageContext } from "./helpers";
 import type { InjectFilterEntry } from "vite-plugin-ssr/types";
@@ -56,11 +56,11 @@ export async function render(pageContext: PageContextServer) {
   const image =
     documentProps?.image ??
     `${import.meta.env.VITE_SITE_URL}/assets/share/generic_landing.png`;
-  
+
   const focusKeywords = pageSeo?.seoFocusKeywords as string[]
 
   const documentHtml = escapeInject`<!DOCTYPE html>
-  <html>
+  <html lang="en">
     <head>
       <meta name="viewport" content="width=device-width, initial-scale=1" />
       <meta httpEquiv="Content-Type" content="text/html; charset=utf-8" />
@@ -81,7 +81,7 @@ export async function render(pageContext: PageContextServer) {
       <meta property="og:video:height" content="720">
       <meta property="og:video:width" content="1280">
 
-      
+
       <!-- Twitter -->
       <meta property="twitter:card" content=${
         documentProps?.video ? "player" : "summary_large_image"
@@ -94,7 +94,7 @@ export async function render(pageContext: PageContextServer) {
       <meta property="twitter:player" content="${documentProps?.video || ""}">
       <meta property="twitter:player:height" content="720">
       <meta property="twitter:player:width" content="1280">
-      
+
       <!-- Google tag (gtag.js) -->
       <script async src="https://www.googletagmanager.com/gtag/js?id=${GOOGLE_TAG_ID}"></script>
       <script>