Add signatures to ProposalPart and Vote and remove ConsensusMessage
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposal parts and votes will be transmitted over different GossipSub topics, therefore they can each have their own message type instead of an enumeration.
matan-starkware
requested review from
ShahakShama,
matan-starkware and
ittaysw
|
The reasoning is that a proposal is a stream of messages and votes are single messages. Stream messages require a different protocol than single messages and so it's not "worth it" to cobble the votes into that protocol. |
ittaysw
approved these changes
Sep 1, 2024
|
Anything else needed for merging this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @matan-starkware off band, we can remove the
ConsensusMessageproto as votes and proposal parts will transmitted over different GossipSub topics and can therefore each have their own message types instead of an enumeration.We therefore need to add a
signaturefield to theVoteandProposalPart(previouslyProposal) protos./cc @matan-starkware @ShahakShama @ittayd