Juno MVP #20
Juno MVP #20
Conversation
To verify the state diff commitment we need to have access to all the fields present in the `StateDiff` returned by the feeder gateway. Therefore, we need to have `deployed_contract` and `replaced_classes` in the `StateDiff` messages. The reason for not including the `DeclaredV0Classes` and `DeclaredV1Classes` is because these can be derived from the `Classes` message, which all Cairo0 and Cairo1 classes can be mapped to `DeclaredV0Classes` and `DeclaredV1Classes`, respectively.
The response to `CurrentBlockHeaderRequest{}` is the peer's local
current header. This can be used to get a rough idea of what the latest
block is as viewed by other peers on the network. The header can be
compared with a subset of peers to determine an efficient way of pulling
blocks from the network while syncing.
Initially, we modified the iteration message to include a `latest`
option, however, since the iteration message is shared by multiple
requests it didn't make sense for each of the messages to have access to
it.
Co-authored-by: Krzysztof Lis <[email protected]>
Co-authored-by: Krzysztof Lis <[email protected]>
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 4 unresolved discussions (waiting on @IronGauntlets)
p2p/proto/block.proto line 33 at r1 (raw file):
Merkle receipts = 10; // By order of issuance. string protocol_version = 11; // Starknet version Felt252 gas_price = 12;
I think that we need two numbers for the gas price, similarly to the rpc-spec (eth_l1_gas_price/strk_l1_gas_price)
p2p/proto/receipt.proto line 32 at r1 (raw file):
uint32 poseidon = 6; uint32 keccak = 7; uint32 output = 8;
output is not needed here, we also removed it from the spec IIRC
p2p/proto/receipt.proto line 46 at r1 (raw file):
ExecutionResources execution_resources = 4; string revert_reason = 5; optional MessageToL2 consumed_message = 6;
Is this needed? we have message hashes in the L1_HANDLER tx receipts, this looks based on the feeder
p2p/proto/state.proto line 26 at r1 (raw file):
} uint32 domain = 1; // volition state domain
Not a blocker for this one, but domain probably not be in the main level (e.g. deployed contracts / declared classes aren't domain-specific)
Yes I will add it in a separate PR and update this branch
Sure will remove
I think this has already been reverted.
Sure, although this PR doesn't modify |
This change is