Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace docker-compose with docker compose #313

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

findinpath
Copy link
Collaborator

Overview

N/A

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • README.md updated and added information about my change
  • I have run changie new to create a changelog entry

@github-actions
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@hovaesco
Copy link
Contributor

Tests are red but it looks unrelated to the change.
cc @damian3031

@damian3031
Copy link
Member

Tests are red but it looks unrelated to the change. cc @damian3031

It's unrelated, these tests are also failing on master. I'll create separate issue and investigate that.

@damian3031
Copy link
Member

damian3031 commented Jun 30, 2023

@findinpath
could you also update these lines?
https://github.com/starburstdata/dbt-trino/blob/v1.5.0/CONTRIBUTING.md?plain=1#L47-L49

@findinpath findinpath force-pushed the findinpath/docker-compose-upgrade branch from 5b92950 to fb1f026 Compare June 30, 2023 09:34
@damian3031
Copy link
Member

I would add changelog entry about switching to docker compose v2, as this is major version bump https://github.com/docker/compose#about-update-and-backward-compatibility

Quote by default the field name if it has constraints.
@findinpath findinpath force-pushed the findinpath/docker-compose-upgrade branch from fb1f026 to 416cab4 Compare July 3, 2023 08:31
@findinpath
Copy link
Collaborator Author

I would add changelog entry about switching to docker compose v2,

@damian3031 this change affects AFAIK only the test environment. I don't see it noteworthy at the moment. However, please point me where to add the change notes if you feel strongly about it.

@damian3031
Copy link
Member

I would add changelog entry about switching to docker compose v2,

@damian3031 this change affects AFAIK only the test environment. I don't see it noteworthy at the moment. However, please point me where to add the change notes if you feel strongly about it.

fair enough, I am not strongly in favor of it

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@findinpath findinpath force-pushed the findinpath/docker-compose-upgrade branch from 416cab4 to 656b097 Compare July 3, 2023 12:36
@findinpath findinpath merged commit 39444b2 into master Jul 3, 2023
11 checks passed
@damian3031 damian3031 deleted the findinpath/docker-compose-upgrade branch September 24, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants