Add type for datetime format to allow autocompletion #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grubersjoe
commented
Dec 14, 2024
| @@ -73,6 +73,7 @@ | |||
| }, | |||
| "license": "MIT", | |||
| "dependencies": { | |||
| "@types/dateformat": "^5.0.2", | |||
There was a problem hiding this comment.
For some reason version 4 was skipped for this, but I've checked. Version 5 of dateformat did not change the format masks, so should be fine.
grubersjoe
force-pushed
the
improve-types
branch
from
1aedd95 to
b683d9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey. Thanks for this package, it's very useful. I've noticed that the
formatoption simply usesstringas type and has no autocompletion. So I think this can be improved by adding the@types/dateformatpackage and then constructing the type based on that. Works nicely:I've consciously added
@types/dateformatto the dependencies and not devDependencies, I think this should be right if thed.tsfile of this package relies on it (so it's part of the API of this package).