SFW-295 Fix dagger always returning the same view model instance, ret…

…urn a new one instead as ViewModelProviders is taking care of this for us when we want it

di/README.md

@@ -132,7 +132,6 @@ class HomeFragment : Fragment(), HasSupportFragmentInjector {
 There is not much to do for ViewModels except for adding a constructor annotated with `@Inject`:
 
 ```kotlin
-@FragmentScope
 class HomeViewModel @Inject constructor(/* inject properties here if you want */) : ViewModel() {}
 ```
 

di/src/main/java/io/stanwood/framework/arch/di/factory/ViewModelFactory.kt

@@ -23,11 +23,11 @@ package io.stanwood.framework.arch.di.factory
 
 import androidx.lifecycle.ViewModel
 import androidx.lifecycle.ViewModelProvider
-import dagger.Lazy
 import javax.inject.Inject
+import javax.inject.Provider
 
 class ViewModelFactory<T : ViewModel> @Inject constructor(
-    private val viewModel: Lazy<T>
+    private val viewModel: Provider<T>
 ) : ViewModelProvider.Factory {
     @Suppress("UNCHECKED_CAST")
     override fun <T : ViewModel?> create(modelClass: Class<T>): T = viewModel.get() as T